Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Makefiles #257

Closed
wants to merge 1 commit into from
Closed

Conversation

zhangwt-cn
Copy link

Fixes #254

Proposed Changes

  • Move packaging -> build/
  • Modified creating-a-release.md common.mk path
  • Cancel .gitignore /build

@nwneisen
Copy link
Collaborator

Hi @zhangwt-cn Thank you for the PR!

Unfortunately, this is only a piece of the needed changes. We will also need to modify our Makefiles before we can introduce this change. Otherwise, our build output will still go to the build/ directory and be mixed together with the packaging folder.

I corrected the formatting on the original issue so that it is hopefully more clear. I'll leave this open and continue to review any additional changes you make. Thanks again for working on this!

- Move packaging -> build/
- Modified creating-a-release.md common.mk path
- Cancel .gitignore /build

Close Mirantis#254
@zhangwt-cn
Copy link
Author

Hi @zhangwt-cn Thank you for the PR!

Unfortunately, this is only a piece of the needed changes. We will also need to modify our Makefiles before we can introduce this change. Otherwise, our build output will still go to the build/ directory and be mixed together with the packaging folder.

I corrected the formatting on the original issue so that it is hopefully more clear. I'll leave this open and continue to review any additional changes you make. Thanks again for working on this!

Thank you for your reminder, I modified it. If there are any other problems, I will be happy to improve it.

@nwneisen
Copy link
Collaborator

Hey @zhangwt-cn,

Let's take a look at the Makefile in the project's root also. Looking at it I can see the following still:

  • Move/Remove the global variables at the top of the file so they are all in build/common.mk and shared throughout the project
  • Update the global variables so they are correct. i.e. PACKAGING_DIR should now point to the Makefile in build/packaging
  • Remove duplicate targets that already exist in build/packaging/Makefile. i.e. deb, rpm, cross-*, etc

Thanks!

@nwneisen nwneisen closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate Makefiles
2 participants