Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IMappingFile.getField to require descriptor #4

Open
LexManos opened this issue Aug 27, 2021 · 0 comments
Open

Change IMappingFile.getField to require descriptor #4

LexManos opened this issue Aug 27, 2021 · 0 comments

Comments

@LexManos
Copy link
Member

LexManos commented Aug 27, 2021

This isn't important in Minecraft world as Proguard doesn't reuse names for fields in the same class.
However for completeness sake we should do this.
It would be nullable, and obviously fallback to the insensitive map if the loaded mappings do not contain field types.

This is most likely {to prevent having to do hacky stuff} a breaking change, as we'd remove the non-descriptor function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant