Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Options not updated in MLJ.fit #236

Open
MilesCranmer opened this issue Jul 26, 2023 · 0 comments
Open

[BUG]: Options not updated in MLJ.fit #236

MilesCranmer opened this issue Jul 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@MilesCranmer
Copy link
Owner

When the parameters in a SRRegressor change from one call to fit! to the next (warm start), the options are cached and not updated. So the SRRegressor state should be hashed and options re-created if the hash value changes.
@MilesCranmer MilesCranmer added the bug Something isn't working label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MilesCranmer