Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character encoding error handling #66

Open
joyously opened this issue Aug 22, 2020 · 0 comments
Open

Character encoding error handling #66

joyously opened this issue Aug 22, 2020 · 0 comments

Comments

@joyously
Copy link

I'm not sure of the internals of how Diffuse works, but there is something wrong with the flow when there is a character encoding problem.
I was using Meld since I needed to compare all files in a folder and one of my files showed a message that there was a character encoding problem, and subsequently, no highlighting of differences.
meld-problem

It didn't tell me where in the file though, so I opened that file in Diffuse. Unfortunately, Diffuse shows highlighting that indicates that everything is a mismatch, and no errors.
diffuse-problem

Trying to use the arrows to find the next mismatch didn't work, so I went to the bottom of the file, which is where I found some extra characters. But still, no indication why the diff highlighting isn't correct.
diffuse-end

Looking at that part of the file in Meld, the error message at least makes more sense. It looks like Meld substituted null bytes for display, and highlighted them red, where nothing else is highlighted.
meld-end

I'm not sure what the best handling of this sort of error is, but I think the Meld way was a bit more informative. Having obvious matching text shown as a difference makes me question if Diffuse is doing it right in other scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant