Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clue scroll config does not seem to work #4

Open
neckothy opened this issue Aug 15, 2022 · 1 comment
Open

Clue scroll config does not seem to work #4

neckothy opened this issue Aug 15, 2022 · 1 comment

Comments

@neckothy
Copy link

neckothy commented Aug 15, 2022

Had multiple people encounter this issue. Still sends announcements even if the clue value is below the minimum value set.

edit: Seems to still send clue notifications even when unchecked, reproduced by a few friends.

Perhaps duplicate logic for this somewhere? I see two different calls to clueNotifier.handleNotify(), the 2nd of which doesn't seem to have any if (config.notifyClue()). Only glanced at code and don't actually know Java, so just tossing out a guess. My apologies if it's unrelated.
call 1:

clueNotifier.handleNotify(numberCompleted, scrollType);

call 2:
clueNotifier.handleNotify(clueCount, clueType);

@neckothy neckothy changed the title Clue scroll minimum value does not seem to work Clue scroll config does not seem to work Aug 22, 2022
MidgetJake added a commit that referenced this issue Aug 25, 2022
Finally getting to these after feeling super burnt out for a while.

- Fixed issue with clue scroll min value not working correctly (Issue #4)
- Fixed certain collection item names being trucated (Issue #6)
- Fixed slayer task not actually showing the task completed (Issue #5)
- Fixed pet notifier sending the incorrect message (Issue #7)

- Can now add multiple webhooks, seperating them by new lines (#2)
@MidgetJake
Copy link
Owner

Thanks for taking a proper look! Wasn't quite to do with those calls. I had the check for the total value of the clue and the minimum value in the wrong place. so it was just removing any icons instead of not sending the notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants