From 418004d81b02330950c73833adc2b0edfb7747b9 Mon Sep 17 00:00:00 2001 From: NatureHog <55314658+NatureHog@users.noreply.github.com> Date: Thu, 31 Oct 2024 16:45:37 +0100 Subject: [PATCH] v9.9 (#7262) - DietPi-DDNS | Resolved an issue where the YDNS update test failed due to a changed response from the server API. Many thanks to @NatureHog for reporting and solving the issue: https://github.com/MichaIng/DietPi/pull/7262 --- CHANGELOG.txt | 1 + dietpi/dietpi-ddns | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index b095a80132..fade43399b 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -7,6 +7,7 @@ Enhancements: Bug fixes: - NanoPi M1 Plus | Resolved an issue where Ethernet did not work because of a faulty kernel patch. Many thanks to @InnovoMagicCube and @InnovoDeveloper for reporting this issue: https://github.com/MichaIng/DietPi/issues/6974 +- DietPi-DDNS | Resolved an issue where the YDNS update test failed due to a changed response from the server API. Many thanks to @NatureHog for reporting and solving the issue: https://github.com/MichaIng/DietPi/pull/7262 As always, many smaller code performance and stability improvements, visual and spelling fixes have been done, too much to list all of them here. Check out all code changes of this release on GitHub: https://github.com/MichaIng/DietPi/pull/ADDME diff --git a/dietpi/dietpi-ddns b/dietpi/dietpi-ddns index 2b33e6bfd7..b19b4ce35d 100755 --- a/dietpi/dietpi-ddns +++ b/dietpi/dietpi-ddns @@ -223,15 +223,15 @@ Apply() # shellcheck disable=SC2086 if ! result=$(curl $ipfamily -sSfL ${http_auth:+ -u "$USERNAME:$PASSWORD"} "$url" 2>&1) || [[ $PROVIDER == 'DuckDNS' && $result == 'KO' ]] || - [[ $PROVIDER == 'YDNS' && $result != 'ok' ]] || + [[ $PROVIDER == 'YDNS' && $result != 'good'* && $result != 'nochg'* ]] || [[ $PROVIDER == 'Dynu' && $result != 'good'* && $result != 'nochg'* ]] then - G_DIETPI-NOTIFY 1 "DDNS update test failed, please check your input${result:+:\n$result}" STATUS="DDNS update test failed, please check your input${result:+:\n$result}" + G_DIETPI-NOTIFY 1 "$STATUS" return 1 else - G_DIETPI-NOTIFY 2 "DDNS update test succeeded${result:+:\n$result}" STATUS="DDNS update test succeeded${result:+:\n$result}" + G_DIETPI-NOTIFY 2 "$STATUS" fi # Check and in case remove obsolete No-IP client