Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-update does not check all tags for versions on github #231

Open
raspher opened this issue Mar 4, 2024 · 3 comments
Open

nix-update does not check all tags for versions on github #231

raspher opened this issue Mar 4, 2024 · 3 comments

Comments

@raspher
Copy link

raspher commented Mar 4, 2024

Hi, an example package i've tried to update: quickwit which have a lot of tags. However none of tags were found on first page (?) and it gives up.

modified a little update script to use regex

src = fetchFromGitHub {
    owner = "quickwit-oss";
    repo = pname;
    rev = "v${version}";
    hash = "sha256-stlm3oDMQVoMza3s4JApynXbzhrarfXw3uAxGMZQJqs=";
  };
[...]
  passthru.updateScript = nix-update-script {
    extraArgs = [ "--version-regex" "v([0-9.]+)" ];
   };

And i've got this after nix-update -u quickwit inside root of nixpkgs repository.

--- SHOWING ERROR LOG FOR quickwit-0.6.4 ----------------------

Traceback (most recent call last):
  File "/nix/store/8iq9mwxyzyamsnyrsbgscvflq60n55hm-nix-update-1.2.0/bin/.nix-update-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/8iq9mwxyzyamsnyrsbgscvflq60n55hm-nix-update-1.2.0/lib/python3.11/site-packages/nix_update/__init__.py", line 291, in main
    package = update(options)
              ^^^^^^^^^^^^^^^
  File "/nix/store/8iq9mwxyzyamsnyrsbgscvflq60n55hm-nix-update-1.2.0/lib/python3.11/site-packages/nix_update/update.py", line 352, in update
    update_hash = update_version(
                  ^^^^^^^^^^^^^^^
  File "/nix/store/8iq9mwxyzyamsnyrsbgscvflq60n55hm-nix-update-1.2.0/lib/python3.11/site-packages/nix_update/update.py", line 290, in update_version
    new_version = fetch_latest_version(
                  ^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/8iq9mwxyzyamsnyrsbgscvflq60n55hm-nix-update-1.2.0/lib/python3.11/site-packages/nix_update/version/__init__.py", line 125, in fetch_latest_version
    raise VersionError(
nix_update.errors.VersionError: Not version matched the regex. The following versions were found:
qw-fulmicoton14
qw-meerkat
qw-guilload
qw-fulmicoton13
qw-wal
qw-airmail
qw-fulmicoton12
qw-fulmicoton11
qw-grpc-gossip
qw-fulmicoton10

not all versions/tags were listed here, probably didn't check more tags

@Mic92
Copy link
Owner

Mic92 commented Mar 6, 2024

nix-update uses this feed to check for tags: curl https://github.com/quickwit-oss/quickwit/releases.atom

It's unclear to me why it doesn't contain those version tags in it.

@Mic92
Copy link
Owner

Mic92 commented Mar 6, 2024

Ah. I think what happened here is that they spammed a lot of tags to there repository so that actual releases are no longer included.

@jvanbruegge
Copy link
Contributor

This is probably fixed by #246 because that only lists releases, not tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants