Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce naming convention for SurfEmiss #158

Open
smnewman opened this issue Mar 1, 2023 · 3 comments
Open

Enforce naming convention for SurfEmiss #158

smnewman opened this issue Mar 1, 2023 · 3 comments
Assignees

Comments

@smnewman
Copy link
Contributor

smnewman commented Mar 1, 2023

The IODA naming conventions define the group SurfEmiss for surface emissivity:
https://github.com/JCSDA-internal/ioda/blob/develop/share/ioda/yaml/validation/ObsSpace.yaml#L112.
However, in opsinputs VarField_mwemiss is mapped to Emiss/emissivity.
https://github.com/MetOffice/opsinputs/blob/develop/src/opsinputs/opsinputs_varobswriter_mod.F90#L861

Accompanied by the change Emiss/emissivity -> SurfEmiss/emissivity for yamls in sith, source code in opsinputs should reflect the new naming convention.

See https://github.com/MetOffice/sith/issues/163.

@smnewman
Copy link
Contributor Author

@mikecooke77 I had forgotten about this issue. As of now, it doesn't seem too important to me. We could allow the old-style name to persist in yamls for VarObs Writer. What do you think?

@mikecooke77
Copy link
Collaborator

We could do. I think at some point it would be nice to deal with but if its get forgotten in the sands of time then so be it. I think worth leaving the issue open.

@ctgh
Copy link
Collaborator

ctgh commented Mar 7, 2024

@smnewman / @mikecooke77 , do you still want to keep this issue open? No problem if so, just checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants