Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal error: character buffer exhausted. #151

Open
hiker opened this issue Dec 9, 2024 · 1 comment
Open

Internal error: character buffer exhausted. #151

hiker opened this issue Dec 9, 2024 · 1 comment

Comments

@hiker
Copy link

hiker commented Dec 9, 2024

Running lfric skeleton with vernier aborts:

Internal error: character buffer exhausted.

The limit of 100 character is seriously way too low given the potentially very long names created by PSyclone. The actual question is - do you really need a static maximum symbol length??

Skeleon worked with:

git diff src/c++/hashtable.cpp
diff --git a/src/c++/hashtable.cpp b/src/c++/hashtable.cpp
index 0c7c74f..800d5ac 100644
--- a/src/c++/hashtable.cpp
+++ b/src/c++/hashtable.cpp
@@ -15,7 +15,7 @@
 #include <iterator>
 
 #define PROF_HASHVEC_RESERVE_SIZE 1000
-#define PROF_STRING_BUFFER_LENGTH 100
+#define PROF_STRING_BUFFER_LENGTH 1000
 
 /**
  * @brief Hashtable constructor
@mo-mglover
Copy link
Collaborator

The explicit maximum is there to avoid dynamic memory allocation, which added a significant performance overhead compared with a static-size std::array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants