Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DAX #4

Open
jsunico opened this issue Feb 3, 2023 · 4 comments
Open

Support for DAX #4

jsunico opened this issue Feb 3, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jsunico
Copy link

jsunico commented Feb 3, 2023

Description

Thanks for your work, @Melchyore! Is there a plan to support DAX connections soon? From the documentation, it seems that DAX is set up differently.

I will try to contribute as well if there are no plans yet. Thank you!

Relevant Information

Dyngoose connection for DAX - https://github.com/benhutchins/dyngoose/blob/master/docs/Connections.md#dynamodb-accelerator-dax

@Melchyore
Copy link
Owner

@jsunico Hey!

From the docs, it seems that you need to pass a custom property to the decorator. It should work. Did you try anything that didn't work? Or are you expecting a new feature?

@jsunico
Copy link
Author

jsunico commented Feb 6, 2023

Hi @Melchyore! Thanks for the response. I'm considering configuring DAX globally in the new adonisjs app that we're starting. However, while reading the code, I believe the default would be the Dynamodb connection. Would there be an option to configure DAX globally?

Dyngoose.Config.default.setConnection(new Dyngoose.Connection.DynamoDBConnection(this.config))

@Melchyore
Copy link
Owner

Melchyore commented Feb 7, 2023

@jsunico Hey!
I will work on it as soon as I have some free time (and I also need to remove the monkey-patch I'm doing to set the connection).

Is it urgent?

@Melchyore Melchyore added this to V2 Feb 7, 2023
@Melchyore Melchyore self-assigned this Feb 7, 2023
@jsunico
Copy link
Author

jsunico commented Feb 9, 2023

It's not urgent for me @Melchyore. I'm still at the POC stage for our new project. Thank you so much!

@Melchyore Melchyore added the enhancement New feature or request label Feb 9, 2023
@Melchyore Melchyore moved this to 🏗 In progress in V2 Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants