Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block workflow when gerrit connection is broken #71

Open
cdir opened this issue Aug 6, 2019 · 0 comments
Open

Do not block workflow when gerrit connection is broken #71

cdir opened this issue Aug 6, 2019 · 0 comments

Comments

@cdir
Copy link

cdir commented Aug 6, 2019

Seems like it was already considered. In NoOpenReviews I found the comment:

 // If there's an error, best not to block the workflow, and just act like it passes??

followed by

throw new WorkflowException(e);

I think it is way better to not block the workflow. At the moment we cannot close any subtask while having issue #70. Maybe there is an easy way to show a warning in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant