Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android Nougat #5

Open
troyjperales opened this issue Aug 26, 2016 · 9 comments
Open

Support Android Nougat #5

troyjperales opened this issue Aug 26, 2016 · 9 comments
Milestone

Comments

@troyjperales
Copy link
Contributor

troyjperales commented Aug 26, 2016

Looks like the FontManager is not getting initialized (which is causing immediate app crashes) on Android N:

https://github.com/MeetMe/font-compat/blob/master/library/src/main/java/com/meetme/support/fonts/FontManager.java#L46

Maybe even consider making the latest implementation the default for API version numbers greater than the latest at the time, so as to not require an update when a new OS version is released.

@troyjperales
Copy link
Contributor Author

It looks like Nougat (Build.VERSION.SDK_INT == 24) is landing on FontManagerImpl21 instead of FontManagerImpl24:

java.lang.NoSuchMethodError: No virtual method addFontWeightStyle(Ljava/lang/String;IZ)Z in class Landroid/graphics/FontFamily; or its super classes (declaration of 'android.graphics.FontFamily' appears in /system/framework/framework.jar)
                                                                                           at com.meetme.support.fonts.FontManagerImpl21.makeFamilyFromParsed(FontManagerImpl21.java:68)
                                                                                           at com.meetme.support.fonts.FontManagerImpl21.init(FontManagerImpl21.java:53)
                                                                                           at com.meetme.support.fonts.FontManagerImpl21.init(FontManagerImpl21.java:44)
                                                                                           at com.meetme.support.fonts.FontManager.install(FontManager.java:66)

@troyjperales
Copy link
Contributor Author

@iainalba
Copy link
Contributor

iainalba commented Sep 1, 2016

I have made some minor changes to fix this issue:

#6

@juanchosaravia
Copy link

Just curious, after merging this PR, are you going to create a new Release version or what do you recommend for this? Thanks!

jhansche pushed a commit that referenced this issue Jun 15, 2017
Support Android Nougat #5
@devfrey
Copy link

devfrey commented Jul 20, 2017

@jhansche Come on, we need a new release version!

@jhansche
Copy link
Contributor

1.1-SNAPSHOT has been built and published. Please test the snapshot and confirm that this issue is resolved.

@jhansche jhansche added this to the 1.1 milestone Jul 31, 2017
@fangzhzh
Copy link

fangzhzh commented Aug 1, 2017

@jhansche FYI it works for me on API 25.

thanks

@RickBoyerDev
Copy link

@jhansche - you mention above that you published an update, how do I reference it?

I tried:
compile 'com.meetme.android:font-compat:1.1-SNAPSHOT@aar'

But it fails to resolve. Is there a different location for the SNAPSHOTS?

Thanks!

@RickBoyerDev
Copy link

@jhansche, you can disregard my earlier question. As I mention in Issue 7, I found that Android O/8.0 now supports font resources and it was added to the support library, so no library needed.

Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants