From d4c93433318192531e21c9a9a4f59325e2c9b49b Mon Sep 17 00:00:00 2001
From: Boubaker Khanfir <boubaker.khanfir@exoplatform.com>
Date: Thu, 2 May 2024 15:39:52 +0100
Subject: [PATCH] fix: Fix Accessibility for Layout buttons - MEED-3263 -
 Meeds-io/meeds#1913 (#50)

This change will improve accessibility score for layout editor button
added in top navigation and in sites management UI.

(Resolves Meeds-io/meeds#1835)
---
 .../vue-app/site-management/components/SiteCardMenu.vue   | 8 ++++++++
 .../site-navigation/components/SiteNavigationButton.vue   | 2 ++
 2 files changed, 10 insertions(+)

diff --git a/layout-webapp/src/main/webapp/vue-app/site-management/components/SiteCardMenu.vue b/layout-webapp/src/main/webapp/vue-app/site-management/components/SiteCardMenu.vue
index 51b3a12d5..645007f57 100644
--- a/layout-webapp/src/main/webapp/vue-app/site-management/components/SiteCardMenu.vue
+++ b/layout-webapp/src/main/webapp/vue-app/site-management/components/SiteCardMenu.vue
@@ -36,6 +36,8 @@
     <v-list class="pa-0" dense>
       <v-list-item
         v-if="isPortalSite && !isGlobalSite"
+        :aria-label="$t('siteManagement.label.properties')"
+        role="button"
         class="subtitle-2 px-3"
         @click="openSitePropertiesDrawer">
         <v-icon
@@ -50,6 +52,8 @@
         </v-list-item-title>
       </v-list-item>
       <v-list-item
+        :aria-label="$t('siteManagement.label.navigation')"
+        role="button"
         class="subtitle-2 px-3"
         @click="openSiteNavigationDrawer">
         <v-icon
@@ -65,6 +69,8 @@
       </v-list-item>
       <v-list-item
         v-if="!isGroupSite && !isGlobalSite"
+        :aria-label="$t('siteManagement.label.manageAccess')"
+        role="button"
         class="subtitle-2 px-3"
         @click="$root.$emit('open-manage-permissions-drawer', site, true)">
         <v-icon
@@ -80,6 +86,8 @@
       </v-list-item>
       <v-list-item
         v-if="canDelete"
+        :aria-label="$t('siteManagement.label.delete')"
+        role="button"
         class="subtitle-2 px-3"
         @click="$root.$emit('delete-site', site)">
         <v-icon
diff --git a/layout-webapp/src/main/webapp/vue-app/site-navigation/components/SiteNavigationButton.vue b/layout-webapp/src/main/webapp/vue-app/site-navigation/components/SiteNavigationButton.vue
index d9f851859..36809dcbb 100644
--- a/layout-webapp/src/main/webapp/vue-app/site-navigation/components/SiteNavigationButton.vue
+++ b/layout-webapp/src/main/webapp/vue-app/site-navigation/components/SiteNavigationButton.vue
@@ -26,8 +26,10 @@
         height="22"
         flat>
         <v-btn
+          :aria-label="$t('siteNavigation.button.tooltip.label')"
           :disabled="disabled"
           class="absolute-vertical-center mt-1"
+          role="button"
           outlined
           icon
           @click="openSiteNavigationDrawer">