Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy warning on missing Eq derive #61

Open
bgilbert opened this issue Oct 5, 2022 · 0 comments
Open

Clippy warning on missing Eq derive #61

bgilbert opened this issue Oct 5, 2022 · 0 comments

Comments

@bgilbert
Copy link
Contributor

bgilbert commented Oct 5, 2022

Clippy 1.63.0 added a warning for types that derive PartialEq but not Eq, and could have derived Eq. As a result, many types generated by schemafy produce Clippy warnings:

warning: you are deriving `PartialEq` and can implement `Eq`
  --> src/mod.rs:18:1
   |
18 | / schemafy!(
19 | |     root: Config
20 | |     "schema.json"
21 | | );
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
   = note: this warning originates in the macro `schemafy` (in Nightly builds, run with -Z macro-backtrace for more info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant