Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additionally Units #38

Open
DanieliMi opened this issue Jan 24, 2019 · 3 comments
Open

Additionally Units #38

DanieliMi opened this issue Jan 24, 2019 · 3 comments

Comments

@DanieliMi
Copy link

As #22 already mention squaremeter is missing and with it some more.
We got the following list of units our customer want to include. I'll provide a PR for it and hope it gets merged. Some of the units are very uncommon but I guess having more in the module is better anyway so everyone can use the one he needs.

m³
Dtzd
Garn
km
Paar (pair)
Pack
m²
Rolle
Satz
Set
Std
Stk. (piece)
t
DanieliMi added a commit to iMi-digital/BasePrice that referenced this issue Jan 25, 2019
@DanieliMi
Add more default units - Magenerds#22 Magenerds#38
baf700d
@DanieliMi
Copy link
Author

I created #39
I reduced the list to the most common tho, because some written above are not important.

@amenk
Copy link

amenk commented Sep 16, 2019 •
edited
Loading

Bump Does this have a chance to get merged

@dasgibtesnureinmal
Copy link

PUSH....
Stk.... would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amenk @DanieliMi @dasgibtesnureinmal