New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace native serialize function with abstract serializer #24

Closed

Detzler wants to merge 1 commit into Magenerds:master from Detzler:bugfix/serialization-error-on-magento-2.2

Detzler commented Jan 8, 2018

Fixes #23

Instead using native serialize function, the fix implements the usage of the serializer interface.
I've tested at a real project. Works fine.

This fix does not include backward compatibility which would look like:

On module upgrade get the value via unserialize function
save the value via the serializer interface

Steps to install the fixed module:

Delete the module from the database
DELETE FROM setup_moduleWHEREsetup_module.module = 'Magenerds_BasePrice'
Delete cache
php bin/magento cache:clean
Install module
php bin/magento setup:upgrade


          Replace native serialize function with abstract serializer

e547fd5

Author

Detzler commented Jan 8, 2018

Oh, there is already a fix lol
never mind

Detzler closed this

Detzler deleted the bugfix/serialization-error-on-magento-2.2 branch

January 8, 2018 14:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet