Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add viscous and surface_tension logicals #688

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add viscous and surface_tension logicals #688

wants to merge 8 commits into from

Conversation

wilfonba
Copy link
Collaborator

@wilfonba wilfonba commented Nov 5, 2024 •
edited
Loading

Description

Add surface_tension and viscous logicals.

Fixes #677 , #668

Type of change

Please delete options that are not relevant.

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Built and ran test suite locally on CPUs and on Frontier with GPUs.

@sbryngelson sbryngelson linked an issue Nov 5, 2024 that may be closed by this pull request
Add a surface_tension boolean input parameter #668
Open
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 19.84733% with 105 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (e2ceaf5) to head (6ab5b79).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_riemann_solvers.fpp 8.92% 1 Missing and 50 partials ⚠️
src/simulation/m_rhs.fpp 20.83% 0 Missing and 19 partials ⚠️
src/simulation/m_viscous.fpp 0.00% 0 Missing and 10 partials ⚠️
src/simulation/m_sim_helpers.f90 0.00% 0 Missing and 6 partials ⚠️
src/simulation/m_global_parameters.fpp 55.55% 0 Missing and 4 partials ⚠️
src/common/m_variables_conversion.fpp 0.00% 1 Missing and 2 partials ⚠️
src/post_process/m_global_parameters.fpp 33.33% 0 Missing and 2 partials ⚠️
src/pre_process/m_global_parameters.fpp 33.33% 0 Missing and 2 partials ⚠️
src/simulation/m_data_output.fpp 66.66% 0 Missing and 2 partials ⚠️
src/simulation/m_mpi_proxy.fpp 0.00% 0 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   42.89%   42.94%   +0.04%     
==========================================
  Files          61       61              
  Lines       16070    16087      +17     
  Branches     1799     1807       +8     
==========================================
+ Hits         6893     6908      +15     
+ Misses       8191     8183       -8     
- Partials      986      996      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

needs checkers:

  • if viscous and Re(1 or 2) == dflt_real -> stop
  • if Re(1 or 2) > 0 and not viscous -> stop
  • if surface_tension and sigma == dflt -> stop
  • if sigma == dflt and not surface_tension -> stop

Also every example that uses viscosity or surface tension needs these logical variables added to their case.py file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbryngelson sbryngelson Awaiting requested review from sbryngelson sbryngelson is a code owner

@henryleberre henryleberre Awaiting requested review from henryleberre henryleberre is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add viscous flag instead of any(Re_size > 0) Add a surface_tension boolean input parameter
2 participants
@wilfonba @sbryngelson