Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI duplicates code to build MFC #660

Open
sbryngelson opened this issue Oct 22, 2024 · 0 comments
Open

CI duplicates code to build MFC #660

sbryngelson opened this issue Oct 22, 2024 · 0 comments
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

sbryngelson commented Oct 22, 2024 •
edited
Loading

Different CI files all do the same thing, something like calling this:

MFC/.github/workflows/cleanness.yml

Line 27 in f125c24

sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev

Which isn't really a big deal, until we change dependencies or something.

It would be useful if maybe we had a way of consolidating this? Or even exposing it to the user for different OSs.

For example, right now I think the linked line needs to apt install fftw.
@sbryngelson sbryngelson added enhancement New feature or request continuous-integration Continuous integration (CI) labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbryngelson