Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdma_mpi to test suite #598

Open
sbryngelson opened this issue Aug 31, 2024 · 3 comments
Open

Add rdma_mpi to test suite #598

sbryngelson opened this issue Aug 31, 2024 · 3 comments
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request good first issue Good for newcomers

Comments

@sbryngelson
Copy link
Member

sbryngelson commented Aug 31, 2024

Add rdma_mpi = 'T' to test suite. This only gets turned on in OpenACC (GPU) mode, which only exists on the Phoenix GPU runner and the Frontier runner, both of which support it.

Note: There needs to be a way to skip this test if the compiler does not support it (in non-CI cases).

@sbryngelson sbryngelson added enhancement New feature or request good first issue Good for newcomers continuous-integration Continuous integration (CI) labels Aug 31, 2024
@sbryngelson
Copy link
Member Author

sbryngelson commented Aug 31, 2024

One option: add --rdma to ./mfc.sh test as an optional flag that adds RDMA tests and is used in CI, but is off by default.

Or, per @henryleberre suggestion: ./mfc.sh test --gpu -- -c frontier -- --rdma which passes to ./mfc.sh run directly rather than relying on the test suite to support this functionality.

@aricer123
Copy link
Contributor

"Add rdma_mpi = 'T' to test suite" I'm a little confused by what this means.
So far, I have created a flag for test that passes to run provided that we are running on a gpu/gpu mode.
Is there a feature already that runs RDMA tests if an --rdma flag is set in run? What work has been done with this feature so far and what more do I need to implement?

@sbryngelson
Copy link
Member Author

Is there a feature already that runs RDMA tests if an --rdma flag is set in run?

No, it is set in the case.py file. This (currently nonexistent) flag, or something like it, would have to be added so turning on this feature could also be controlled from the command line.

This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants