Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite does not touch any --case-optimization cases #225

Closed
sbryngelson opened this issue Nov 8, 2023 · 3 comments
Closed

Test suite does not touch any --case-optimization cases #225

sbryngelson opened this issue Nov 8, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

The current test suite does not do any case optimization cases. Is it possible to compile a single test case that uses all the case optimization parameters (bubbles, 3D, etc.) and add it as a one-off test? would this double the run-time of our test suite?

@sbryngelson sbryngelson added the enhancement New feature or request label Nov 8, 2023
@henryleberre
Copy link
Member

This should be rather straightforward to add. It would currently require two partial rebuilds of simulation (once for a --case-optimization case and once for all others) as well as the serialization of the --case-optimization test case(s) - you would run into issues with running multiple of these cases concurrently. The cost is probably negligeable, however. There are was we could get around this but it would most likely be over-engineering.

@sbryngelson
Copy link
Member Author

--case-optimization could be added to the test suite matrix for one select case that has "all the case optimization features" and for a couple select runners (at least one CPU and one GPU). This seems like the most straightforward solution.

@sbryngelson sbryngelson linked a pull request Jan 3, 2024 that will close this issue
@sbryngelson
Copy link
Member Author

This can be closed because benchmarking runs case optimization cases, so we will know if it breaks (at least for the most part).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants