Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.1 of PyTNG #108

Closed
IAlibay opened this issue Oct 28, 2023 · 13 comments
Closed

Release 0.3.1 of PyTNG #108

IAlibay opened this issue Oct 28, 2023 · 13 comments
Assignees

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 28, 2023

A release of pytng is necessary in order to allow for py3.12 support - this is blocking the core library here: MDAnalysis/mdanalysis#4327

@hmacdope
Copy link
Member

Ill cut now?

@hmacdope hmacdope self-assigned this Oct 28, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

@hmacdope what's your release procedure? It should match the new deployment workflow

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

New release procedure should be:

  1. Make & push tags
  2. Check GH action for testpypi push worked fine
  3. Make release
  4. Check GH action for pypi push worked fine

@hmacdope
Copy link
Member

Normally, cut tag on main, pull, then push to PyPi from my own computer, I assume the new workflow makes it easier?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

Normally, cut tag on main, pull, then push to PyPi from my own computer, I assume the new workflow makes it easier?

yeah you don't need to do any of that anymore, wheel building should be automatic - assuming the workflow doesn't have any bugs (it'll probably fail the first time around knowing how these things go).

@hmacdope
Copy link
Member

hmacdope commented Oct 28, 2023

Cutting directly on github will trigger or do i need to actually push the tags from local?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

@hmacdope

Yes, just doing this will work:

git tag -m "release 0.3.1 of pytng" v0.3.1
git push --tags origin

Then when CI passes you can just do a release using that new tag.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

Looks like the wheel upload went fine: https://test.pypi.org/project/pytng/#files

Should be good to cut a release.

@hmacdope
Copy link
Member

Legendary, thanks so much. Good practice for me to understand the no-local workflow as well.

@hmacdope
Copy link
Member

Done and tested.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

@hmacdope you're probably going to need to update the conda-forge recipe quite a bit because of the numpy pins, iirc the current defaults aren't the same as what conda-forge expects.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

I don't think I'm a maintainer for that recipe but if you ping me for review I can add the necessary changes.

@hmacdope
Copy link
Member

Cheers, will do. Thanks for sorting this out I was very slow, my apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants