-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow bonds etc to be additively guessed when present #4761
base: develop
Are you sure you want to change the base?
Conversation
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-27 01:41:54 UTC |
(Current status of PR: tests are failing due to #4762, assuming they pass after that's resolved, this should be ready for review.) |
@yuxuanzhuang if you have time to look at this, it'd be great if you could see if this resolves the original issue in #4759! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4761 +/- ##
===========================================
+ Coverage 93.59% 93.64% +0.04%
===========================================
Files 177 189 +12
Lines 21710 22808 +1098
Branches 3052 3055 +3
===========================================
+ Hits 20320 21358 +1038
- Misses 943 1003 +60
Partials 447 447 ☔ View full report in Codecov by Sentry. |
Fixes #4759
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4761.org.readthedocs.build/en/4761/