Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDAnalysis.analysis.hydrogenbonds.WaterBridgeAnalysis: Implement parallelization or mark as unparallelizable #4666

Open
marinegor opened this issue Aug 20, 2024 · 0 comments

Comments

@marinegor
Copy link
Contributor

Given a newly implemented parallelization (https://docs.mdanalysis.org/dev/documentation_pages/analysis/parallelization.html), implement it for all classes in analysis.hydrogenbonds.WaterBridgeAnalysis module. You may use analysis.RMSD in develop as a reference.

You need to add:

  • appropriate implementation of result aggregation for AnalysisBase subclasses in analysis.hydrogenbonds.WaterBridgeAnalysis module (or explicitly limit available backends if the classes aren't parallelizable)
  • a boilerplate fixture(s) to testsuite/analysis/conftest.py, analogous with existing ones
  • a client_... fixtures to all tests using in testsuite/MDAnalysisTests/analysis/test_waterdynamics.py, and modify the way run() method is called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants