Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation and warnings for composer-patches configuration #370

Open
deviantintegral opened this issue Jan 30, 2024 · 2 comments · May be fixed by #717
Open

Add validation and warnings for composer-patches configuration #370

deviantintegral opened this issue Jan 30, 2024 · 2 comments · May be fixed by #717
Assignees
@beto-aveiga
Labels
enhancement New feature or request question Further information is requested

Comments

@deviantintegral
Copy link
Member

While we probably shouldn't enforce these ADRs, we could certainly log a warning if any of these configurations are not as expected.

I think we could do this in a composer install hook?

https://architecture.lullabot.com/adr/20220429-composer-patchlevel/
https://architecture.lullabot.com/adr/20220429-composer-patches-inline/
https://architecture.lullabot.com/adr/20220429-composer-patch-files/
https://architecture.lullabot.com/adr/20220429-composer-exit-failure/
@deviantintegral deviantintegral added the enhancement New feature or request label Jan 30, 2024
@deviantintegral deviantintegral added the question Further information is requested label Feb 19, 2024
@beto-aveiga
Copy link
Collaborator

@deviantintegral: regarding https://architecture.lullabot.com/adr/20220429-composer-patches-inline/ ... and considering we have a tool like Drainpipe, why not allow the user to use a different patch file and join the composer file with the patches file at the moment of validation?
composer.json already has enough information, and if we can have a separation for patches and have a full validation of the composer contents, that would be the best scenario for developers.

@beto-aveiga beto-aveiga linked a pull request Oct 2, 2024 that will close this issue
ISSUE-370: composer configuration checks #717
Open
@beto-aveiga
Copy link
Collaborator

This one is ready for review at #717

@mrdavidburns mrdavidburns linked a pull request Oct 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beto-aveiga beto-aveiga

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-370: composer configuration checks Lullabot/drainpipe
2 participants
@deviantintegral @beto-aveiga