Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream issues: fixes and features in other tools that would benefit Pavex #72

Open
LukeMathWalker opened this issue Jun 7, 2023 · 2 comments

Comments

@LukeMathWalker
Copy link
Owner

LukeMathWalker commented Jun 7, 2023

This is a meta-issue to keep track of feature requests/bugs in other projects that affect Pavex.

@LukeMathWalker LukeMathWalker pinned this issue Jun 7, 2023
@LukeMathWalker LukeMathWalker unpinned this issue Jun 16, 2023
@aDotInTheVoid
Copy link

Heads up: We might be changing how rustdoc-json handles paths in a way that might break you. Details are in rust-lang/rust#134880. If you use the Crate::paths field you should be fine, but if you rely on Path::name for resolving cross-crate paths then this will break you. Please comment on that PR if moving to Crate::paths doesn't work somehow. Thanks!

@LukeMathWalker
Copy link
Owner Author

I have a feeling this might be an issue, but I have to go and review the relevant code paths. I'll try to carve some time tomorrow.
Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants