Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of LuaJIT test suite #129

Open
MikePall opened this issue Jan 31, 2016 · 3 comments
Open

Cleanup of LuaJIT test suite #129

MikePall opened this issue Jan 31, 2016 · 3 comments

Comments

@MikePall
Copy link
Member

MikePall commented Jan 31, 2016

I've just added: https://github.com/LuaJIT/LuaJIT-test-cleanup

The intention is that all cleanups and refactoring should happen over there. Please discuss everything needed for this to happen over there. Feel free to open issues as needed. Anyone who wants commit access, please see: LuaJIT/LuaJIT-test-cleanup#1

When everything is done, it should be merged into this repo 'flat', without the history. The cleanup history will be quite messy and not very useful here. [TBD whether this is to be merged or split off, too.]

@cryptomilk
Copy link

Hi,

I'm currently the maintainer of LuaJIT in Fedora. I added the LuaJIT-test-cleanup repo to our package and with minimal changes the tests are passing.

I see that there are several pull requests in the repo, but they all just bitrot. Is there still a plan to integrate the tests or remove them entirely?

@MikePall
Copy link
Member Author

MikePall commented Sep 9, 2023

I do not think distros should be doing the testing. Various people are already running permanent CI tests and fuzzers. And with special debug/assert builds, which have a much higher likelihood than production builds to turn up anything.

When, if and how the tests are merged or split is yet to be determined.

@cryptomilk
Copy link

Oh, it is part of the packaging process to run tests. You really want that as a distribution:

a) We often build on more platforms than developers do (x86, arm, ppc, s390, ...)
b) You want to know in a distro if an update of a package breaks another package.
c) Untested code is broken code ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants