Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match workflow of Ripple pipeline with spyglass standards #1188

Open
samuelbray32 opened this issue Nov 14, 2024 · 0 comments
Open

Match workflow of Ripple pipeline with spyglass standards #1188

samuelbray32 opened this issue Nov 14, 2024 · 0 comments
Labels
enhancement New feature or request ripple

Comments

@samuelbray32
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Most spyglass pipelines/schema follow the pattern (DataSource, ParamsTable) -> SelectionTable -> ComputeTable
  • Ripple pipeline breaks this pattern.
    • RippleLFPSelection only defines what lfp data and electrodes to use, with no foreign key reference to the params or position data
    • RippleTimesV1 (the compute table) has foreign key references to RippleLFPSelection, PositionOutput and RippleParameters itself rather than a single selection table
  • This works but breaks our standards without a particularly unusual reason to do so
  • Was confusing for at least me when I went back to run existing entries with different parameters

Describe the solution you'd like
RippleTimesV2 which has an intermediate table RippleTimesSelection in order to follow Spyglass conventions

Additional context
Happy to take input if there's any reasons besides historical for this structure

@samuelbray32 samuelbray32 added enhancement New feature or request ripple labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ripple
Projects
None yet
Development

No branches or pull requests

1 participant