You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Most spyglass pipelines/schema follow the pattern (DataSource, ParamsTable) -> SelectionTable -> ComputeTable
Ripple pipeline breaks this pattern.
RippleLFPSelection only defines what lfp data and electrodes to use, with no foreign key reference to the params or position data
RippleTimesV1 (the compute table) has foreign key references to RippleLFPSelection, PositionOutput and RippleParameters itself rather than a single selection table
This works but breaks our standards without a particularly unusual reason to do so
Was confusing for at least me when I went back to run existing entries with different parameters
Describe the solution you'd like RippleTimesV2 which has an intermediate table RippleTimesSelection in order to follow Spyglass conventions
Additional context
Happy to take input if there's any reasons besides historical for this structure
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
DataSource
,ParamsTable
) ->SelectionTable
->ComputeTable
RippleLFPSelection
only defines what lfp data and electrodes to use, with no foreign key reference to the params or position dataRippleTimesV1
(the compute table) has foreign key references toRippleLFPSelection
,PositionOutput
andRippleParameters
itself rather than a single selection tableDescribe the solution you'd like
RippleTimesV2
which has an intermediate tableRippleTimesSelection
in order to follow Spyglass conventionsAdditional context
Happy to take input if there's any reasons besides historical for this structure
The text was updated successfully, but these errors were encountered: