Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdrAckCounter not incremented on "wrong" downlink frame received #1549

Open
sda3422 opened this issue Jun 29, 2023 · 1 comment
Open

AdrAckCounter not incremented on "wrong" downlink frame received #1549

sda3422 opened this issue Jun 29, 2023 · 1 comment

Comments

@sda3422
Copy link

sda3422 commented Jun 29, 2023

Hi, version used is tag v4.7.0.
In LoRaMac.c function StopRetransmission.
The Nvm.MacGroup1.AdrAckCounter is not incremented when a LoRa frame has been received (so MacCtx.MacFlags.Bits.McpsInd is set) on an RX window but the status of this reception is not LORAMAC_EVENT_INFO_STATUS_OK.
In this case, in my opinion, Nvm.MacGroup1.AdrAckCounter should be incremented.
What do you think ?
Thank you.

@pjb-loxius
Copy link

pjb-loxius commented Jun 29, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants