Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom VM images for CI builds (OSOE-717) #607

Open
Piedone opened this issue Nov 6, 2023 · 1 comment
Open

Use custom VM images for CI builds (OSOE-717) #607

Piedone opened this issue Nov 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Nov 6, 2023

Once github/roadmap#826 is available, let's use custom VM images for CI builds.

The image used for .NET builds should contain all build dependencies preinstalled, as well as an OSOCE source built that'll be updated on checkout (or if that's not possible, then re-cloned, but still, we'd have the NuGet and NPM caches warm). Perhaps saving OSOCE after also a test run would be useful, to let the UI Testing Toolbox install its dependencies (smtp4dev, Zap) too.

This should be regenerated when OSOCE dev changes; most possibly, after every dev commit it'd be wasteful, but perhaps once every day if there are new dev commits.

Once this works with package caches, package caching in the build workflow can be disabled.

If this works out well, we can introduce it in all other projects of ours too.

Related:

Jira issue

@Piedone Piedone added the enhancement New feature or request label Nov 6, 2023
@github-actions github-actions bot changed the title Use custom VM images for CI builds Use custom VM images for CI builds (OSOE-717) Nov 6, 2023
@BenedekFarkas
Copy link
Member

BenedekFarkas commented Nov 9, 2023

This should be regenerated when OSOCE dev changes; most possibly, after every dev commit it'd be wasteful, but perhaps once every day if there are new dev commits.

Last time I built the official GH image it was around 4-5 hours I think, but we can reuse that image and build our own on top of that. Based on what I know now, our own image build should be around 10 minutes or less, but we can further refine the conditions and only regenerate it when the OSOCE NuGetTest folder/solution is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants