-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrive the Admin prefix from AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-657)
#209
Comments
AdminOptions.AdminUrlPrefix
instead of hardcoding itAdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-657)
AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-657)AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-653)
AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-653)AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-657, OSOE-653)
AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-657, OSOE-653)AdminOptions.AdminUrlPrefix
instead of hardcoding it (OSOE-657)
I believe the idea there is that |
Yes, it's like this for the sake of UI testing (here is the extension above mentioned). When I created At any rate, if we want to load the admin prefix from configuration, we must make sure if falls back to the sensible default of "/Admin" gracefully and doesn't throw. |
Indeed, in the UI Testing Toolbox we should access For the UITT use case we'll need to be able to optionally pass the prefix to `TypedRoute too. |
For info, if |
Related comment: #208 (comment)
Here:
https://github.com/Lombiq/Helpful-Libraries/blob/dev/Lombiq.HelpfulLibraries.OrchardCore/Mvc/TypedRoute.cs#L96
Retrive the Admin prefix from
AdminOptions.AdminUrlPrefix
instead of hardcoding it.Jira issue
The text was updated successfully, but these errors were encountered: