-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust cancel-workflow-on-failure defaults (OSOE-571) #211
Comments
cancel-workflow
action from workflows with a single jobcancel-workflow
action from workflows with a single job (OSOE-571)
It does cancel other workflows' jobs too, isn't it? In that case it's just a matter of updating the name and maybe adding a description. |
Oh, right! I overlooked that. I guess, then we don't need to change it (although I agree that it could be named slightly more clearly). |
cancel-workflow
action from workflows with a single job (OSOE-571)
What name would make it clearer for you? |
Tbh, looking at this again, I see now that the actions I've referred to will most often be used as part of a larger workflow. Somehow, I missed that. So I guess, the improvement we could make is setting |
I think changing that would be problematic if multiple workflows are triggered at the same time (or if that's not the case now, you'd need to remember that when adding a new workflow). |
I don't quite understand. |
We can set it to |
Do you still deem this important enough to tackle? If yes, we should adjust the title here and in JIRA. |
Updated. |
Once done, the "Saving on computing resources" docs section will need to be adjusted too. |
Adjust the default value of the
cancel-workflow-on-failure
workflow parameter based on the usual usage.We can set it to
false
forpublish-nuget
, for example, which is a reusable workflow that will usually be used alone, not as one job among many in a larger workflow (where the workflow cancellation matters). For such workflows, it could even be the default, as well as forcreate-jira-issues-for-community-activities
andvalidate-submodule-pull-request
andvalidate-pull-request
. Check all the existing workflows though.https://github.com/Lombiq/Open-source-template should also be updated.
Jira issue
The text was updated successfully, but these errors were encountered: