Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature proposal: User Profile Page Update #28

Closed
souravpaul8 opened this issue Jun 14, 2020 · 3 comments · Fixed by #56
Closed

New feature proposal: User Profile Page Update #28

souravpaul8 opened this issue Jun 14, 2020 · 3 comments · Fixed by #56
Labels
accepted backend work related to backend module:user related to users module

Comments

@souravpaul8
Copy link
Contributor

Child of #17

Using POST request I'll accept the parameters and values that are to be changed and change those parameters in the database.
@YashKumarVerma
@lockedup-bot
Copy link

lockedup-bot bot commented Jun 14, 2020

Thanks @souravpaul8, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@YashKumarVerma YashKumarVerma added accepted backend work related to backend module:user related to users module labels Jun 14, 2020
@souravpaul8
Copy link
Contributor Author

souravpaul8 commented Jun 16, 2020 •
edited
Loading

@YashKumarVerma Can you confirm me few things:

  1. The username corresponding to the user whose details have to be updated will be in the body (not params)
  2. Can a user update his username?
  3. The body of the request will contain only properties to be changed and their corresponding value.

@YashKumarVerma
Copy link
Member

@YashKumarVerma Can you confirm me few things:

  1. The username corresponding to the user whose details have to be updated will be in the body (not params)
  2. Can a user update his username?
  3. The body of the request will contain only properties to be changed and their corresponding value.
  • yes, in the body.
  • username cannot be updated.
  • the body will send an object containing all details of the user. old + new.

@souravpaul8 souravpaul8 mentioned this issue Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted backend work related to backend module:user related to users module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Update profile feature souravpaul8/nostalgify
2 participants
@YashKumarVerma @souravpaul8