Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature Proposal : User login and logout #22

Closed
tanay13 opened this issue Jun 14, 2020 · 7 comments
Closed

New feature Proposal : User login and logout #22

tanay13 opened this issue Jun 14, 2020 · 7 comments
Labels
accepted backend work related to backend module:user related to users module

Comments

@tanay13
Copy link
Member

tanay13 commented Jun 14, 2020

Child of #17

What i plan to do is

  • using local strategy of passport i will authenticate the username and password that the user is entering
  • If it is valid details then i will redirect the page to user profile and if its a failure then i will redirect it again to /login page
  • for logout i will use req.logout() and will redirect it to the home page
@lockedup-bot
Copy link

lockedup-bot bot commented Jun 14, 2020

Thanks @tanay13, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@YashKumarVerma YashKumarVerma added accepted backend work related to backend module:user related to users module labels Jun 14, 2020
@YashKumarVerma
Copy link
Member

You'll have to setup passport for this project.

@tanay13
Copy link
Member Author

tanay13 commented Jun 14, 2020

yes i will do it

@YashKumarVerma
Copy link
Member

updates ?

@tanay13
Copy link
Member Author

tanay13 commented Jun 16, 2020

@YashKumarVerma I have sent the PR .
Should i delete the previous PR i had sent?

@YashKumarVerma
Copy link
Member

Ensure that only one active PR is there for one issue.

@tanay13
Copy link
Member Author

tanay13 commented Jun 16, 2020

@YashKumarVerma Okay i will keep that in mind

@tanay13 tanay13 closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted backend work related to backend module:user related to users module
Projects
None yet
Development

No branches or pull requests

2 participants