Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature Proposal: SignUp page #21

Closed
hayat-tamboli opened this issue Jun 13, 2020 · 6 comments · Fixed by #30
Closed

New feature Proposal: SignUp page #21

hayat-tamboli opened this issue Jun 13, 2020 · 6 comments · Fixed by #30
Labels
accepted frontend work related to frontend module:user related to users module

Comments

@hayat-tamboli
Copy link
Member

child issue of #18

HTML layout(code): https://github.com/hayat-tamboli/frontend-work/blob/master/SignUp.html

HTML preview: https://hayat-tamboli-frontend-work.glitch.me/SignUp.html
@lockedup-bot
Copy link

lockedup-bot bot commented Jun 13, 2020

Thanks @hayat-tamboli, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@YashKumarVerma YashKumarVerma added frontend work related to frontend module:user related to users module proposal proposal for task labels Jun 14, 2020
@YashKumarVerma YashKumarVerma mentioned this issue Jun 14, 2020
Closed
@YashKumarVerma
Copy link
Member

@hayat-tamboli

Few changes:

  1. remove navbar
  2. Make sure image is copyright free
  3. Move the input form inside a card
  4. use<small> styling or similar for the line: already have an account? Log In
  5. Change text : SignUp to something more interactive.

@YashKumarVerma YashKumarVerma removed the proposal proposal for task label Jun 14, 2020
@hayat-tamboli
Copy link
Member Author

made all changes

@YashKumarVerma tell me if any other changes are needed.

@YashKumarVerma
Copy link
Member

@hayat-tamboli

  • create a folder named reference
  • create folder named reference/assets/
  • create folder named reference/assets/css
  • create folder named reference/assets/js
  • create folder named reference/assets/images
  • make sure you put all the css , js, image files your code depends on in the css , js, image folder.
  • make sure your code does not use CDN and use these local files.

@hayat-tamboli
Copy link
Member Author

@hayat-tamboli

  • create a folder named reference
  • create folder named reference/assets/
  • create folder named reference/assets/css
  • create folder named reference/assets/js
  • create folder named reference/assets/images
  • make sure you put all the css , js, image files your code depends on in the css , js, image folder.
  • make sure your code does not use CDN and use these local files.

should I make that folder in src or root

@YashKumarVerma
Copy link
Member

Instructions posted in #18

hayat-tamboli added a commit to hayat-tamboli/nostalgify that referenced this issue Jun 14, 2020
@hayat-tamboli
updated integrations to close LockedUp-Coders#21
2c4394b
@hayat-tamboli hayat-tamboli mentioned this issue Jun 14, 2020
Merged
YashKumarVerma pushed a commit that referenced this issue Jun 14, 2020
@hayat-tamboli
updated integrations to close #21 (#30)
8276873
YashKumarVerma added a commit that referenced this issue Jun 14, 2020
@vivekshah1801 @PrachiSinghal86 @YashKumarVerma
Add EJS Supprt (#33)
85ce5da 
* Update README.md (#9)

* added EJS support

* Create .integrations

Update .travis.yml

updated integrations to close #21 (#30)

added EJS support

ejs final done

Co-authored-by: PrachiSinghal86 <[email protected]>
Co-authored-by: Yash Kumar Verma <[email protected]>
hayat-tamboli added a commit to hayat-tamboli/nostalgify that referenced this issue Jun 20, 2020
@hayat-tamboli
updated integrations to close LockedUp-Coders#21
5e83e02 
fixes LockedUp-Coders#52 

changes: added Organization profile page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted frontend work related to frontend module:user related to users module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated integrations to close #21 hayat-tamboli/nostalgify
2 participants
@YashKumarVerma @hayat-tamboli