Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: add commit quality check #2033

Closed
4 tasks
pamfilos opened this issue Jan 18, 2021 · 1 comment · Fixed by Lilykos/analysispreservation.cern.ch#6 or #2058 · May be fixed by Lilykos/analysispreservation.cern.ch#9, Lilykos/analysispreservation.cern.ch#10 or Lilykos/analysispreservation.cern.ch#11
Closed
4 tasks

global: add commit quality check #2033

pamfilos opened this issue Jan 18, 2021 · 1 comment · Fixed by Lilykos/analysispreservation.cern.ch#6 or #2058 · May be fixed by Lilykos/analysispreservation.cern.ch#9, Lilykos/analysispreservation.cern.ch#10 or Lilykos/analysispreservation.cern.ch#11
Assignees
@Lilykos
Labels
Type: new feature

Comments

@pamfilos
Copy link
Collaborator

Feature request

What is the expected behavior?

We should update the commit quality checking

  • Detect typos in subject, message
  • check that commit is signed
  • max length of commit subject (<50 chars)
  • all these (and others) on top of current checks
@papadopan
Copy link
Contributor

I am adding this as a suggestion might be useful
https://github.com/conventional-changelog/commitlint

Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
5ac919a 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 26, 2021
Closed
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
71f1c41 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
6172690 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 26, 2021
Closed
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
bfa8409 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
0189bc8 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
2f97c34 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 26, 2021
@Lilykos
global: add gitlint for commit message checks
75ff6c8 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 27, 2021
@Lilykos
global: add gitlint for commit message checks
0156488 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 27, 2021
Merged
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 27, 2021
@Lilykos
global: add gitlint for commit message checks
2b61465 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 27, 2021
@Lilykos
global: add gitlint for commit message checks
0e0d7ea 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 27, 2021
@Lilykos
global: add gitlint for commit message checks
df32b9b 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 27, 2021
Merged
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 27, 2021
@Lilykos
global: add gitlint for commit message checks
8e82d03 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 28, 2021
@Lilykos
global: add gitlint for commit message checks
e44a92e 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 28, 2021
Closed
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 28, 2021
@Lilykos
global: add gitlint for commit message checks
6239104 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 28, 2021
@Lilykos
global: add gitlint for commit message checks
00c7b42 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 28, 2021
@Lilykos
global: add gitlint for commit message checks
d715868 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 28, 2021
@Lilykos
global: add gitlint for commit message checks
b8e8e33 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
a688e0b 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
553944b 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 29, 2021
Open
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
7096744 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
15452a6 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
221be60 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
9d76db9 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
81ff568 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
47094c7 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 29, 2021
Closed
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
33f82cf 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos mentioned this issue Jan 29, 2021
Open
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
45da9c9 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
6bd5bb8 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
a22a72b 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
4fb7394 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
22e9046 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
cd6d703 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
aadaf76 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
45cd24c 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
6e25943 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
2515924 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
ba729c3 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
93223ec 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
edd5888 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
497e98d 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
663f9e7 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
25003b9 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
105c98d 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
9ab78fc 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
e44669b 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 29, 2021
@Lilykos
global: add gitlint for commit message checks
2d303a9 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
papadopan pushed a commit to papadopan/analysispreservation.cern.ch that referenced this issue Feb 4, 2021
@Lilykos @papadopan
global: add gitlint for commit message checks
f376af3 
* closes cernanalysispreservation#2033

Signed-off-by: Ilias Koutsakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilykos Lilykos

Labels
Type: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
global: add gitlint for commit message checks Lilykos/analysispreservation.cern.ch
3 participants
@Lilykos @pamfilos @papadopan