Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisted disk cache for cardinality queries #378

Open
keski opened this issue Jan 17, 2025 · 2 comments · May be fixed by #379
Open

Persisted disk cache for cardinality queries #378

keski opened this issue Jan 17, 2025 · 2 comments · May be fixed by #379
Assignees
Labels
enhancement New feature or request

Comments

@keski
Copy link
Collaborator

keski commented Jan 17, 2025

The FederationAccessManagerWithCache currently maintains cardinality query results in an in-memory cache. This issue concerns implementing a basic disk-based caching mechanism that persists cardinality queries and their results to disk. This will enable CLI-based executions to share a simple persistent cache across runs.

Future enhancements will introduce features such as time-based eviction policies to improve cache management.

@keski keski added the enhancement New feature or request label Jan 17, 2025
@keski keski self-assigned this Jan 17, 2025
@keski
Copy link
Collaborator Author

keski commented Jan 24, 2025

There is now a basic implementation (FederationAccessManagerWithPersistedDiskCache) including tests in this branch. Note that I've only implemented the caching of SPARQL cardinality requests at this time. I based the implementation on a modified version of the FederationAccessManagerWithCache.

@hartig, it would be great if you could provide feedback on the general structure of the code, but especially on the tests since I felt they were a bit tricky.

@hartig
Copy link
Member

hartig commented Jan 24, 2025

Please create a PR. That makes it easier for me to provide feedback.

@keski keski linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants