Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent a PR from fixing a blocked issue. #6

Open
Levi-Lesches opened this issue Jul 18, 2022 · 0 comments
Open

Prevent a PR from fixing a blocked issue. #6

Levi-Lesches opened this issue Jul 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Levi-Lesches
Copy link
Owner

Consider:

  • Issue 1 (open)
  • Issue 2, blocked Issue 1
  • PR 2, fixes Issue 2 (using a closing keyword)

Since PR 2 addresses Issue 2, it is inherently blocked by Issue 1. However, if it does not explicitly mention Issue 1, there is nothing stopping it from being merged anyway and closing Issue 2 before Issue 1 is resolved. To counter this, I will add a new check that fails when a PR fixes an issue that is labeled as blocked.
@Levi-Lesches Levi-Lesches mentioned this issue Jul 18, 2022
Closed
@Levi-Lesches Levi-Lesches added the enhancement New feature or request label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Levi-Lesches