Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esc] doesn't work to close full-screen editor #37

Open
LogicalJoe opened this issue Jul 29, 2021 · 2 comments
Open

[esc] doesn't work to close full-screen editor #37

LogicalJoe opened this issue Jul 29, 2021 · 2 comments

Comments

@LogicalJoe
Copy link
Contributor

Solutions include: adding a button to close the full-screen editor.

@LogicalJoe
Copy link
Contributor Author

LogicalJoe commented Jul 30, 2021

Update: [esc] does actually close the editor but only when the cursor is in the text input box. Could it be made to work when the textbox is not selected?

@Legend-of-iPhoenix
Copy link
Owner

Legend-of-iPhoenix commented Jul 31, 2021

I can repro this in chrome/firefox, this is not an issue specific to safari but rather one with the userstyle.
I'm certain that this is caused by the keyup event listener being on .posteditor_columns and not the window itself.

I think the merging of #38 resolves the underlying problem of the screen being annoying to close by adding a close button. I'll keep this issue open because it is unintuitive behavior worth looking at, though.

@LogicalJoe LogicalJoe changed the title [esc] doesn't work to close full-screen editor in Safari [esc] doesn't work to close full-screen editor Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants