Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware contracts should publish an image containing smart contracts for integration testing #44

Open
1 of 3 tasks
shrimalmadhur opened this issue Nov 1, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@shrimalmadhur
Copy link

shrimalmadhur commented Nov 1, 2023

Currently how we do integration testing is using foundry docker image and deploy all the contracts (eigenlayer contracts and middleware contracts) https://github.com/Layr-Labs/eigensdk-go/blob/67be9ea97fb92a3ee090ab12b56e34e97010a76d/cmd/egnaddrs/main_test.go#L50

But it would be great if middleware repo can publish a docker image of deployed contracts state which any repository (incredible squaring, eigenlayer-cli) can use as a base image to test onchain interaction

AC

  • create design doc to make sure we're all on the same page
  • get people to review the design doc
  • published docker image with deployed eigenlayer core contract + eigenlayer middleware contracts.
@shrimalmadhur shrimalmadhur added the enhancement New feature or request label Nov 1, 2023
@samlaf
Copy link
Contributor

samlaf commented Nov 1, 2023

+1 we really need this. This way also the contracts are published with consistent versioning, and a team can decide which versions of the contracts to test against, in a consistent manner (say if they decide to publish their contracts with older version of the middleware contracts)

@samlaf
Copy link
Contributor

samlaf commented Nov 23, 2023

Wrote the design doc. Requesting reviews from @shrimalmadhur @stevennevins @NimaVaziri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants