Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pinned eigenlayer-contracts version is broken #229

Open
taturosati opened this issue Apr 16, 2024 · 1 comment · May be fixed by #230
Open

fix: pinned eigenlayer-contracts version is broken #229

taturosati opened this issue Apr 16, 2024 · 1 comment · May be fixed by #230

Comments

@taturosati
Copy link

Describe the bug
Checked out commit of eigenlayer-contracts submodule script M2_Deploy_From_Scratch.s.sol does not work. The issue is it references old folder script/testing in line 103. This has been fixed on commit 41b4361 on eigenlayer-contracts repo.

To Reproduce
Steps to reproduce the behavior:

  1. Clone eigenlayer-middleware repo on dev branch or release tags v0.1.3-mainnet-m2+pragma-change or v0.1.3-mainnet-m2
  2. Start anvil
  3. Enter lib/eigenlayer-contracts
  4. Run forge script script/testing/M2_Deploy_From_Scratch.s.sol --rpc-url $RPC_URL --private-key $PRIVATE_KEY --broadcast --sig "run(string memory configFile)" -- M2_deploy_from_scratch.anvil.config.json
  5. See error "File not found"

Expected behavior
Eigen Layer contracts should be deployed to anvil

Environment
Enter important environment info needed to reproduce the bug.

  • dev branch
  • v0.1.3-mainnet-m2
  • v0.1.3-mainnet-m2+pragma-change
@Atunde-SS
Copy link

Bug Report: M2_Deploy_From_Scratch.s.sol Script Not Working

Steps to Reproduce:

  1. Clone the eigenlayer-middleware repository from the dev branch or use release tags (e.g., v0.1.3-mainnet-m2+pragma-change or v0.1.3-mainnet-m2).
  2. Start Anvil.
  3. Navigate to lib/eigenlayer-contracts.
  4. Execute the following command:
    forge script script/testing/M2_Deploy_From_Scratch.s.sol --rpc-url $RPC_URL --private-key $PRIVATE_KEY --broadcast --sig "run(string memory configFile)" -- M2_deploy_from_scratch.anvil.config.json
    
  5. Observe the error message: "File not found."

Expected Behavior:
The Eigen Layer contracts should be successfully deployed to Anvil without encountering any file-related issues.

Environment:

  • Branch: dev
  • Release Tags Tested: v0.1.3-mainnet-m2, v0.1.3-mainnet-m2+pragma-change

Suggested Fix:

  1. Update line 103 in the M2_Deploy_From_Scratch.s.sol script to reference the correct folder path.
  2. Verify that the script executes without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants