Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to save id attribute - keeps getting deleted #613

Open
habitus opened this issue Aug 31, 2016 · 9 comments
Open

Not able to save id attribute - keeps getting deleted #613

habitus opened this issue Aug 31, 2016 · 9 comments

Comments

@habitus
Copy link

habitus commented Aug 31, 2016

for example, if I type this sample code:
<p id="top"><a href=https://www.google.com>Link</a></p>
When i hit 'Save', this is what is getting saved down:
<p><a href="http://www.google.com">Link</a></p><p></p>
The id="top" text is not getting saved, and also an addition<p></p> tags are getting added in.

Please help to fix this.

Thanks!

@wwebfor
Copy link
Member

wwebfor commented Sep 3, 2016

It's happening because for default we remove all attributes from HTML tags to avoid XSS attacks. Maybe we can make it optional.

@currentcolor
Copy link

Is there any chance of a workaround?
I wanted to move 'best practices' notes to Laverna.
The XSS concern is fair (probably), but it prevents from including html snippets in Laverna because all attributes disappear.

@draran
Copy link

draran commented Jan 26, 2017

+1 for this enhancement

@mattpalermo
Copy link

Is it possible to escape the note content? So that any content can be safely included? Github is a good example of this.

@sjbuysse
Copy link

Any updates on this enhancement? Would love to have this made optional (since I use laverna offline anyway...)

@spreered
Copy link

spreered commented Oct 3, 2017

+1 for this enhancement please....

@dafunction
Copy link

+1 for a fix/workaround for this

is there any way this can be added as an optional toggle, maybe with some warning to [online] users that upon toggling the option they are vulnerable to XSS attacks, and that the risk lies solely on them?

similar to @currentcolor i am logging all my notes/best practices in Laverna and this is a pretty significant sticking point.

@atlasloewenherz
Copy link

atlasloewenherz commented Dec 9, 2019

+1 for the fix or enhancement!! I 'm also affected. Literally every element with '<' and '>' get deleted

@funilrys
Copy link
Contributor

funilrys commented Dec 9, 2019

Hi @atlasloewenherz @holdcands @spreered @sjbuysse @mattpalermo @draran @currentcolor @habitus

Unfortunately, this issue will never be fixed here.
Please report to #998 for more information about the state of this project.

Have a nice day/night.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants