Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix switch background color when none defined #5757

Closed

Conversation

NuktukDev
Copy link

@NuktukDev NuktukDev commented Jan 25, 2025

#5756

Bug report
The switch background color was broken 4 days ago.

What I did
I used the switch.

What I expected to happen
It would take the default background color defined by tabler.

What happened
It shows a blank color.

What I've already tried to fix it
I fixed it already.

Is it a bug in the latest version of Backpack?
Yes.

After I run composer update backpack/crud the bug... is it still there?
Yes.

Backpack, Laravel, PHP, DB version
Latest backpack, laravel 10, php 8.

When I run php artisan backpack:version the output is:

backpack/basset: 1.3.6
backpack/crud: 6.7.50
backpack/generators: v4.0.7
backpack/medialibrary-uploaders: 1.2.1
backpack/pro: 2.2.32
backpack/theme-tabler: 1.2.17
Additional Information
There is a class switch-{{ $field['color'] }} that doesn't make sense to me, I removed it.

Here's some more info that could be helpful in reproducing or debugging:

Environment details (e.g., operating system, web server, browser): ??
Relevant error logs or screenshots (if any): ??
Note: Issues that cannot be reproduced or lack necessary details to diagnose could be closed.

Copy link

welcome bot commented Jan 25, 2025

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@NuktukDev
Copy link
Author

This corresponds to this issue:
#5756

I'm not sure how to do the PR and an issue report properly.

@jcastroa87 jcastroa87 self-assigned this Jan 27, 2025
@pxpm
Copy link
Contributor

pxpm commented Jan 28, 2025

Thanks for the PR @NuktukDev, much appreciated. Unfortunately we can't merge it as is.

We have already created and merged another PR to fix this issue. I will tag a new CRUD version with the fixes later today 🙏

Cheers

@pxpm pxpm closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants