Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing filters from string or serde_json::Value #8

Open
onelson opened this issue Jul 18, 2021 · 0 comments
Open

Add support for parsing filters from string or serde_json::Value #8

onelson opened this issue Jul 18, 2021 · 0 comments
Milestone

Comments

@onelson
Copy link
Contributor

onelson commented Jul 18, 2021

The motivation for having a type-safe(ish) filter API is to help promote correctness at compile-time when authoring filters, but there are plenty of use cases for parsing filters at runtime too.

To get there, we should provide support for parsing filters from strings, as well as from a serde_json::Value. The filter types have a custom Serialize impl which means we currently only know how to generate json, not parse it. See if we can rework the serde aspect of this to help make both Serialize and Deserialize work.

@onelson onelson added this to the v0.9 milestone Jul 18, 2021
@onelson onelson changed the title Add FromStr impl for the filter types Add support for parsing filters from string or serde_json::Value Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant