Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spheral banner & CMake git dependency #232

Closed
mdavis36 opened this issue Jul 6, 2023 · 0 comments · Fixed by #236 or #254
Closed

Spheral banner & CMake git dependency #232

mdavis36 opened this issue Jul 6, 2023 · 0 comments · Fixed by #236 or #254
Assignees
Labels
good first issue Good for newcomers

Comments

@mdavis36
Copy link
Collaborator

mdavis36 commented Jul 6, 2023

The current Spheral banner displays as such
Spheral version : <Branch> <Hash> <# of all time commits>
We would like to display it as
Spheral version : <Last release version> <# of commits from last tagged release> <Branch> <Hash>
And when the .git folder is not available we would like:
Spheral version : <Last release version>

This should be done by guarding git calls within CMake when repository information is not present.
CMake also currently depends on repo data to generate the list of test files to install, we need to find a way around this without .git.

This will resolve issue #207

@mdavis36 mdavis36 added the good first issue Good for newcomers label Jul 6, 2023
@ldowen ldowen mentioned this issue Jul 21, 2023
3 tasks
@mdavis36 mdavis36 linked a pull request Jan 18, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants