Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for groups extension #260

Merged
merged 13 commits into from
Dec 11, 2023
Merged

add support for groups extension #260

merged 13 commits into from
Dec 11, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Dec 11, 2023

No description provided.

@exaexa exaexa requested a review from giordano December 11, 2023 11:09
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64ec00b) 93.30% compared to head (1d95e0f) 94.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   93.30%   94.93%   +1.63%     
==========================================
  Files          10       10              
  Lines         821      868      +47     
==========================================
+ Hits          766      824      +58     
+ Misses         55       44      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa
Copy link
Collaborator Author

exaexa commented Dec 11, 2023

(@giordano this might take some time to debug but any preliminary comments very welcome :) )

@exaexa
Copy link
Collaborator Author

exaexa commented Dec 11, 2023

note to self: TODO improve coverage with adding sbml testcases

@exaexa exaexa requested a review from stelmo December 11, 2023 12:09
Copy link
Collaborator

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/structs.jl Outdated Show resolved Hide resolved
@exaexa
Copy link
Collaborator Author

exaexa commented Dec 11, 2023

@mihai-sysbio btw if you could have a quick look at src/structs.jl and confirm that it would be sufficient to support the StdGem/YeastGem usecases it would be great :] Thanks!

Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBML 😨

@exaexa exaexa merged commit b9a9f34 into master Dec 11, 2023
14 checks passed
@exaexa exaexa deleted the mk-groups branch December 11, 2023 21:07
@mihai-sysbio
Copy link

@mihai-sysbio btw if you could have a quick look at src/structs.jl and confirm that it would be sufficient to support the StdGem/YeastGem usecases it would be great :] Thanks!

Sorry I was slow to reply. It looks like a very flexible structure is now I place 👍🏻 I must admit I haven't looked into other SBMLs and how the structure these groups, so I would have guessed the Members of a Group would have fewer attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants