-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for groups extension #260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 93.30% 94.93% +1.63%
==========================================
Files 10 10
Lines 821 868 +47
==========================================
+ Hits 766 824 +58
+ Misses 55 44 -11 ☔ View full report in Codecov by Sentry. |
(@giordano this might take some time to debug but any preliminary comments very welcome :) ) |
note to self: TODO improve coverage with adding sbml testcases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@mihai-sysbio btw if you could have a quick look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SBML 😨
Sorry I was slow to reply. It looks like a very flexible structure is now I place 👍🏻 I must admit I haven't looked into other SBMLs and how the structure these groups, so I would have guessed the Members of a Group would have fewer attributes. |
No description provided.