Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink sodiumoxidez fork #32

Open
Dhole opened this issue Jan 8, 2020 · 4 comments
Open

Rethink sodiumoxidez fork #32

Dhole opened this issue Jan 8, 2020 · 4 comments
Labels
discuss Stuff that needs to be discussed

Comments

@Dhole
Copy link
Collaborator

Dhole commented Jan 8, 2020

sodiumoxidez was the fork I made of sodiumoxide that adds the functions to convert from ed25519 to curve25519 which in the original sodiumoxide, but it's implemented in libsodium. Maybe instead of using a fork we should solve this via the kuska-crypto crate? Or maybe we could keep sodiumoxidez and move it here?

@Dhole Dhole added the discuss Stuff that needs to be discussed label Jan 8, 2020
@adria0
Copy link
Member

adria0 commented Jan 12, 2020

It seems that sodiumoxide is not going to add this functionality that has been requested for near 5 years, see https://github.com/sodiumoxide/sodiumoxide/issues/85, https://github.com/sodiumoxide/sodiumoxide/issues/165, sodiumoxide/sodiumoxide#343 and sodiumoxide/sodiumoxide#361.

I prefer writing our own kuska-crypto crate #7 option instead forking it

@adria0 adria0 mentioned this issue Jan 12, 2020
@Dhole
Copy link
Collaborator Author

Dhole commented Jan 15, 2020

I prefer writing our own kuska-crypto crate #7 option instead forking it

Sounds good to me! We can keep this issue open until we make the kuska-crypto crate.

@adria0
Copy link
Member

adria0 commented Feb 26, 2020

What about forking the last version of sodioumoxide repo in this org, adding the changes you made and using it? The current forked version you used have a ugly security advisory:

ID:       RUSTSEC-2019-0026
Crate:    sodiumoxide
Version:  0.2.4
Date:     2019-10-11
URL:      https://rustsec.org/advisories/RUSTSEC-2019-0026
Title:    generichash::Digest::eq always return true
Solution:  upgrade to >= 0.2.5
Dependency tree: 
sodiumoxide 0.2.4

@llebout
Copy link

llebout commented Apr 24, 2020

@adria0 they're annoying, we're asking for typesafe libsodium bindings, not arguments on whether libsodium apis are cryptographically safe or not. smh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Stuff that needs to be discussed
Projects
None yet
Development

No branches or pull requests

3 participants