Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: allow creating new augments #21

Open
eldritch-cookie opened this issue Jan 5, 2024 · 0 comments
Open

Suggestion: allow creating new augments #21

eldritch-cookie opened this issue Jan 5, 2024 · 0 comments

Comments

@eldritch-cookie
Copy link

i was looking at thermal and they have a custom data system for augments such that you can make any item a augment by editing its NBT, so it is relatively simple to make a custom augment.
the problem with this approach is that by adding the augment data in the item instead of globally there could be problems if in a newer version of the modpack the augment values were changed so i thought of just implementing IAugmentItem directly and while it looks possible it looks simpler to add support for creating a item as an augment via an addon. while i could make my own addon this looks to be in scope of kubejs thermal.

what would be the requirements for a PR adding custom augment creation support?

thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant