Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gateway status check optional when using FetchValidGateway and FetchValidTargetRef #429

Closed
mikenairn opened this issue Feb 19, 2024 · 1 comment

Comments

@mikenairn
Copy link
Member

mikenairn commented Feb 19, 2024

What

Update FetchValidGateway to make the checking of the status conditions on the target Gateway optional when deciding whether to return it or not.

Update TLSPolicy to use these common function see

Why

FetchValidTargetRef and FetchValidGateway currently expect that the gateway should have a programmed condition, but in the case of the TLSPolicy it might not be programmed because there is an invalid tls section that this policy would resolve.

@Boomatang
Copy link
Contributor

Closing:

  • Mention file which needs change 404s
  • I am assuming this work is not needed anymore due to using policy machinery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants