Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance how dependency detected flags are passed to workflow stages/reconcilers #1128

Open
KevFan opened this issue Jan 20, 2025 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@KevFan
Copy link
Contributor

KevFan commented Jan 20, 2025

Description

As noted in #994 (comment), we are currently passing a long list of boolean flags to many workflow stages and their dependent reconciliation tasks. This approach makes the order of the boolean flags critical, which negatively impacts maintainability and may lead to potential issues if the order of the flags changes in the future.

We should consider refactoring or enhancing this implementation by exploring options such as:

  • Using a list of options
  • Passing a map
  • Separating the dependency flags into their own struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant