From fdd5a169d538461ecf06e9b2f0fb06242bed0645 Mon Sep 17 00:00:00 2001 From: Tomas Repel Date: Thu, 1 Feb 2024 17:31:46 +0100 Subject: [PATCH] Walkthrough text updates and quickstart.sh missing space fix --- doc/user-guides/secure-protect-connect.md | 6 +++--- hack/quickstart-setup.sh | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/user-guides/secure-protect-connect.md b/doc/user-guides/secure-protect-connect.md index 845a25bef..b7dcad2f5 100644 --- a/doc/user-guides/secure-protect-connect.md +++ b/doc/user-guides/secure-protect-connect.md @@ -33,7 +33,7 @@ Here are the steps we will go through: 8) [Override the Gateway rate limits with an endpoint-specific policy](#-override-the-gateways-ratelimitpolicy) -To help with this walk through, you should set a `KUADRANT_ZONE_ROOT_DOMAIN` environment variable to a domain you want to use. If it you want to try DNSPolicy, this should also be a domain you have access to the DNS for in AWS Route53 or GCP. E.g.: +To help with this walk through, you should set a `KUADRANT_ZONE_ROOT_DOMAIN` environment variable to a domain you want to use. If you want to try DNSPolicy, this should also be a domain you have access to the DNS for in AWS Route53 or GCP. E.g.: ```sh export KUADRANT_ZONE_ROOT_DOMAIN=my.domain.iown @@ -189,7 +189,7 @@ The limit here is artificially low in order for us to show it working easily. Le for i in {1..10}; do curl -k --resolve api.${KUADRANT_ZONE_ROOT_DOMAIN}:443:${INGRESS_HOST} "https://api.$KUADRANT_ZONE_ROOT_DOMAIN/cars" && sleep 1; done ``` -We should see `409`s start returning after the 5th request. +We should see `409 Too Many Requests`s start returning after the 5th request. ### ❺ Define the Gateway AuthPolicy @@ -226,7 +226,7 @@ spec: EOF ``` -Let's test it again. This time we expect a `403`. +Let's test it again. This time we expect a `403 Forbidden`. ```sh curl -k --resolve api.${KUADRANT_ZONE_ROOT_DOMAIN}:443:${INGRESS_HOST} "https://api.$KUADRANT_ZONE_ROOT_DOMAIN/cars" diff --git a/hack/quickstart-setup.sh b/hack/quickstart-setup.sh index 3a8c3b311..315d6ebb6 100755 --- a/hack/quickstart-setup.sh +++ b/hack/quickstart-setup.sh @@ -26,7 +26,7 @@ if [ -z $MGC_REF ]; then MGC_REF=${MGC_REF:="main"} fi -if [ -z $ISTIO_INSTALL_SAIL]; then +if [ -z $ISTIO_INSTALL_SAIL ]; then ISTIO_INSTALL_SAIL=${ISTIO_INSTALL_SAIL:=false} fi